test: get zig build test working
#18207
Open
+566
−499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 6:07 PM PT - Mar 25th, 2025
❌ @DonIsaac, your commit 685c89f has 1 failures in
🧪 try this PR locally: bunx bun-pr 18207 |
190n
requested changes
Mar 17, 2025
190n
requested changes
Mar 20, 2025
| const obj = Build.LazyPath{ .generated = .{ | ||
| .file = bin.generated.file, | ||
| .up = 1, | ||
| .sub_path = "bun-test.o", |
There was a problem hiding this comment.
can you file an issue with Zig asking for a better way to do this and link it here as a TODO?
|
Tests in other files cannot be universially included via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Lets us write and run unit tests directly in Zig.
Running Zig unit tests in CI is blocked by ziglang/zig#23281. We can un-comment relevant code once this is fixed.
Workflow
Test binaries can be made for any kind of build. They are called
<bun>-testand live next to their correspondingbunbin. For example, debug tests compile tobuild/debug/bun-debug-test.Test binaries re-use most cmake/zig build steps from normal bun binaries, so building one after a normal bun build is pretty fast.
How did you verify your code works?
I tested that my tests run tests.